Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONOFF] Fix actuator manual control with button press and overheat protection #1403

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

1technophile
Copy link
Owner

@1technophile 1technophile commented Jan 18, 2023

Description:

Manual control with a button press was triggering the relay but 2 times (when pressing and releasing)
Check that we have 2 consecutive reading of temperature above the threshold to trigger actuator to OFF
And remove it by default to the shelly, as I'm seeing unjustified jump of temperature above 80C

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

Manual control with a button press was triggering the relay but 2 times (when pressing and releasing)
Check that we have 2 consecutive reading of temperature above the threshold to trigger actuator to OFF
And remove it by default to the shelly, as I'm seeing unjustified jump of temperature above 80C
@1technophile 1technophile merged commit b4003d4 into development Jan 19, 2023
@1technophile 1technophile deleted the fix-actuator-control branch January 19, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant