-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User friendly manual network configuration #1715
Conversation
Testing on ESP32s and ESP8266s, including Avatto S06 IR and Sonoff RF Bridge - running smoothly. |
Could you also add a paragraph about this in the documentation? I think it would fit nicely as a separate NOTE after the NOTE
in https://github.com/1technophile/OpenMQTTGateway/blob/development/docs/upload/builds.md Thanks |
Also adding the macros into the following environment: [env:esp32dev-all-test] |
@DigiH @1technophile thanks guys for checking this, docs updated as well. |
Thanks for the Docs update. Could you also add the network build_flags to the [env:esp32dev-all-test] environment, as @1technophile mentioned? This assures constant tests runs with these flags, to avoid future possible regressions. https://github.com/1technophile/OpenMQTTGateway/blob/development/environments.ini#L51 Thanks |
@DigiH done, pls let me know if network parameters (IP, mask etc.) for the test env should be different |
Not caused by you @vi7, I just spotted this next environment not having an empty line before. Small clean up.
Thanks! |
Description:
User_config.h
NOTE: Tested on Wemos D1 mini (ESP8266) ONLY, unfortunately I do not have a possibility to test on Arduino and ESP32
Checklist: