[HA Discovery] Do not deactive autodiscovery when discovery_republish_on_reconnect is enabled #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, do not deactive autodiscovery in certain cases when discovery_republish_on_reconnect is enabled Signed-off-by: Sami Salonen <[email protected]>
ssalonen
force-pushed
the
do-not-disable-autodiscovery-when-republish-on-reconnect
branch
from
c74a3c3 to
d4e4d30
Compare
ssalonen
changed the title
|
Good catch,, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not deactive autodiscovery in certain cases when
discovery_republish_on_reconnect(see #1274 and #1290 ) is enabledThe introduction of
DiscoveryAutoOffTimerin 3f92e14 / #1541 introduced a regression for the re-publishing of discovery topics (discovery_republish_on_reconnect) as first introduced in #1290 - afterDiscoveryAutoOffTimerhas elapsed, the system does not republish the topics even when MQTT connection is re-established.This PR disables the effect of
DiscoveryAutoOffTimerwhendiscovery_republish_on_reconnectis enabledDescription:
Checklist: