[WEBUI] Update ZwebUI.ino - Convert WiFi.SSID() to c_string (JJK) #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1technophile
changed the title
|
Thanks! |
odoral
pushed a commit
to odoral/OpenMQTTGateway
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This fixes ONE of the TWO bugs mentioned in #2012
Specifically, the WiFi Network always displayed as garbage in the WebUI WiFi Configuration screen.
Problem is that WiFi.SSID() needs to be converted to a c_string -- so the fix is trivial.
I am surprised that nobody else has noted this bug as it seemingly applies to all installations and goes back to at least v1.60.
Please add this fix asap as it restores basic WebUI functionality for pretty much all users.
Checklist: