Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYS] Remove handleJsonQueue wrapper and use std::string #2038

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

1technophile
Copy link
Owner

Description:

Remove handleJsonQueue wrapper and use std::string in the queue to reduce Arduino Framework dependency

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@1technophile
Copy link
Owner Author

Can you take a look please @puterboy
This is a first step, I keep in mind the reduction of json<->string transformation

Copy link
Contributor

@puterboy puterboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@1technophile 1technophile merged commit 719976b into development Aug 29, 2024
148 checks passed
@1technophile 1technophile deleted the queue-work branch August 29, 2024 14:44
odoral pushed a commit to odoral/OpenMQTTGateway that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants