[SYS] Fix connection validation on unknown indexes and improve erase method #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connection with Index 1 and 2 were supposed valid when not present in the configuration, generating attempts to connect with those indexes. And improve erase config by adding an erase when the config file is not present (ESP is connected to WiFi without config file). This way the ESP will not reconnect to the WiFi AP
1technophile
added a commit
that referenced
this pull request
Oct 4, 2024
Erasing the nvs before the start of WM prevent WM from starting, revert a part of #2075 Also remove the erase from setupWiFiManager method
1technophile
added a commit
that referenced
this pull request
Oct 4, 2024
Erasing the nvs before the start of WM prevent WM from starting, revert a part of #2075 Also remove the erase from setupWiFiManager method Co-authored-by: Florian <[email protected]>
odoral
pushed a commit
to odoral/OpenMQTTGateway
that referenced
this pull request
Oct 18, 2024
…method (1technophile#2075) Before this fix, connections with Index 1 and 2 were supposed valid when not present in the configuration, generating attempts to connect with those indexes. Also improve the erase config by adding an erase when the config file is not present (ESP is connected to WiFi without the config file). This way the ESP will not reconnect to the WiFi AP. Co-authored-by: Florian <[email protected]>
odoral
pushed a commit
to odoral/OpenMQTTGateway
that referenced
this pull request
Oct 18, 2024
Erasing the nvs before the start of WM prevent WM from starting, revert a part of 1technophile#2075 Also remove the erase from setupWiFiManager method Co-authored-by: Florian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Before this fix, connections with Index 1 and 2 were supposed valid when not present in the configuration, generating attempts to connect with those indexes.
Also improve the erase config by adding an erase when the config file is not present (ESP is connected to WiFi without the config file). This way the ESP will not reconnect to the WiFi AP.
Checklist: