[RF] handle 64 bits values (except for UNO) #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1technophile
changed the title
1technophile
changed the title
1technophile
force-pushed
the
RF-64bits
branch
3 times, most recently
from
8bd7b6d to
0c98777
Compare
Arduino UNO is not enough powerfull to handle properly uint64_t in terms of memory so differenciate the variable type depending on the board type With this configuration ATMega will not be able to receive with simpleReceiving 64 bits values. Of course Json will work with 64 bits values for this board.
Legion2
reviewed
Jul 16, 2020
Co-authored-by: Leon Kiefer <[email protected]>
Legion2
reviewed
Jul 18, 2020
Legion2
reviewed
Jul 18, 2020
|
@Legion2 Thanks for the advices on this PR! |
Legion2
reviewed
Jul 18, 2020
* rename TYPE_UL_ULL to SIGNAL_SIZE_UL_ULL * build deduplication function only when the relevant gateways are built * replace 2 dimensions array by a structure so as to handle the time with an uint32_t when using an ESP (instead of a uint64_t) * change storeValue and isAduplicate function names * point to the rcswitch revision with the new 40 bits protocol
Legion2
approved these changes
Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#693
This PR enables to handle 64 bits values except for Arduino UNO.
Why limiting it on UNO, mainly to reduce the sketch size. To handle 64 bits values we need to activate
ARDUINOJSON_USE_LONG_LONGand this activation generate a too big sketch for the Uno when using the RF gateway.Added to that I found also a limit on arduino boards, the usage of ·´strtoull´ function is not available. This function is not a lot used in the code. Only with the ´simpleReceiving` method.
This method is currently enable by default but the question of its relevantness is asked below :
https://community.openmqttgateway.com/t/vote-removing-simplereceiving-and-simplepublishing/1044
simpleReceiving and simplePublishing enables to receive and send with a lite payload (no json), it was the first data format supported by OpenMQTTGateway.
Now I suspect that json is the mostly i used format.
We could develop an ´strtoull´ for Arduino but before doing that I prefer to know the simpleReceiving usage.