Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino NimBLE support #732

Merged
merged 3 commits into from
Aug 17, 2020
Merged

Arduino NimBLE support #732

merged 3 commits into from
Aug 17, 2020

Conversation

1technophile
Copy link
Owner

@1technophile 1technophile commented Aug 15, 2020

Arduino NIMBLE support (less flash and memory usage, better stability)
Decorrelate the device discovery from the BLE scan so as to avoid canary stack trace error and prepare the future add of BLEconnect

@1technophile 1technophile added this to the v0.9.5 milestone Aug 15, 2020
@1technophile 1technophile changed the title Nim ble support Arduino Nimble support Aug 15, 2020
To avoid Stack canary watchpoint triggered and store sensor model into BLEdevice vector
@1technophile 1technophile changed the title Arduino Nimble support Arduino NimBLE support Aug 15, 2020
Copy link
Contributor

@jmw6773 jmw6773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have a chance to run it an ESP32, but it looks okay..

@1technophile
Copy link
Owner Author

Thanks @jmw6773

@Legion2 do you have other comments for this PR?

@Legion2
Copy link
Contributor

Legion2 commented Aug 17, 2020

@1technophile no I only looked at the code, I did not test it, I have no bluetooth devices.

@1technophile
Copy link
Owner Author

ok, thanks!

@1technophile 1technophile merged commit e9910a9 into development Aug 17, 2020
@1technophile 1technophile deleted the NimBLE-support branch August 17, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants