BLE - Disconnect after a timeout #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1technophile
changed the title
So as to save the devices battery
1technophile
force-pushed
the
ble-connect-disconnect
branch
from
891e8e8 to
6bc618e
Compare
h2zero
reviewed
May 17, 2021
| @@ -569,6 +569,8 @@ void BLEconnect() { | |||
| if (pRemoteCharacteristic->canNotify()) { | |||
| Log.trace(F("Registering notification" CR)); | |||
| pRemoteCharacteristic->subscribe(true, notifyCB); | |||
| delay(BLE_CNCT_TIMEOUT); | |||
There was a problem hiding this comment.
Instead of a delay here we could use a task notification wait with BLE_CNCT_TIMEOUT as the max wait time. The notification callback could release the task before the timeout and this would save time and battery power for both devices if applicable. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So as to save the devices battery