Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hover effect to Register buttons #48

Merged
merged 5 commits into from
Dec 22, 2021

Conversation

geetika005
Copy link
Contributor

Thank you for your contribution 🤩🤩

GitHub license Open Source Love PRs Welcome

Please mention the following in order to get PR merged 🙌🏻🙌🏻

  1. Kind of change this PR introduce : Hover effect is added to the create account and skip button and their font is also changed
  2. Issue it resolves : register buttons hover #47
  3. Screenshots & GitHub Page Link :

2021-12-06 (2)

@2024-SANDHYA
Copy link
Owner

Thank you for your contribution 🤩🤩

GitHub license Open Source Love PRs Welcome

Please mention the following in order to get PR merged 🙌🏻🙌🏻

1. Kind of change this PR introduce : Hover effect is added to the create account and skip button and their font is also changed

2. Issue it resolves : [register buttons hover #47](https://github.com/2024-SANDHYA/Blood-Buddy/issues/47)

3. Screenshots & GitHub Page Link :
2021-12-06 (2)

Provide github page link

@geetika005
Copy link
Contributor Author

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes are reflected.

@geetika005
Copy link
Contributor Author

can you please tell how to create that link?

@2024-SANDHYA
Copy link
Owner

can you please tell how to create that link?

You have not made any changes in the code, so they are not reflected, link is okay

@geetika005
Copy link
Contributor Author

Screenshot_2021-12-17-14-40-28-61_40deb401b9ffe8e1df2f1cc5ba480b12
Screenshot_2021-12-17-14-40-39-71_40deb401b9ffe8e1df2f1cc5ba480b12
Mam i had made changes in register.css file ,you can check my commits

@geetika005
Copy link
Contributor Author

The changes are reflected in my side

@2024-SANDHYA
Copy link
Owner

Please don't use these colors, use some contrast colors, you can refer to this to match the color contrast https://www.canva.com/colors/color-wheel/

@geetika005
Copy link
Contributor Author

2021-12-20 (2)

Please check

@2024-SANDHYA
Copy link
Owner

2024-SANDHYA commented Dec 20, 2021

A big no !! The colors do not look good at all !! Both of them, blue make no sense with red and then the previous one too on the yellowish base. Please use some contrast knowledge ,maintain the theme.

@geetika005
Copy link
Contributor Author

2021-12-20 (5)

2021-12-20 (6)

on hovering create account

@2024-SANDHYA 2024-SANDHYA merged commit b0967c8 into 2024-SANDHYA:main Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

register buttons hover
2 participants