Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description popovers to unclear setup labels #40

Closed
V-ed opened this issue Nov 5, 2019 · 2 comments · Fixed by #50
Closed

Add description popovers to unclear setup labels #40

V-ed opened this issue Nov 5, 2019 · 2 comments · Fixed by #50
Assignees
@V-ed

Comments

@V-ed
Copy link
Member

V-ed commented Nov 5, 2019

Thinking of the new option added for #38...
@V-ed V-ed self-assigned this Nov 5, 2019
@V-ed
Copy link
Member Author

V-ed commented Nov 5, 2019

The only problem I see with this issue would be popovers for mobiles : I had in mind to do this on hover, but you can't hover on mobile, and clicking / tapping already focuses the input field / triggers the action for checkboxes...

Would this issue be covered by #31?

@V-ed
Copy link
Member Author

V-ed commented Nov 10, 2019

but you can't hover on mobile, and clicking / tapping already focuses the input field / triggers the action for checkboxes...

And it doesn't make sense to toggle the checkbox when tapping the label. Simply removing the label connection to the checkbox allows for hover / tapping to display a popover.

V-ed added a commit that referenced this issue Nov 10, 2019
@V-ed
Add checkbox to setup page to select option to vote multiple
9aaccbf 
Also tweaks checkbox labels to allow for hoverable text description, closing #40
@V-ed V-ed mentioned this issue Nov 11, 2019
Merged
@V-ed V-ed closed this as completed in #50 Nov 11, 2019
V-ed added a commit that referenced this issue Dec 4, 2019
@V-ed
Add icon and warning modal about password not being protected
31a8f3d 
This commit also makes all bootstrap label not focus their respective element on click, which helps getting the popover to show and helps further more adding help content such as #40 did already

Closes #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@V-ed V-ed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add possibility to vote multiple times for the same candidate 205stelzear/elections
1 participant
@V-ed