KAZOO-5248: keep doc schemas in sync with ref/ #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These fail because I couldn't find which file corresponds to the ref/ version: |
|
Also, lots of files in ref/ do not have a public version in doc/ |
| return found[0] | ||
|
|
||
| def public_doc(ref_path): | ||
| doc_root = os.path.split(os.path.split(ref_path)[0])[0] |
There was a problem hiding this comment.
why not os.path.dirname(path) ?
jamhed
pushed a commit
to jamhed/kazoo
that referenced
this pull request
Dec 23, 2016
* KAZOO-5248: segregate schemas in ref docs * KAZOO-5248: add missing schemas * KAZOO-5248: fix assoc * KAZOO-5248: add missing schema * KAZOO-5248: fix spacing in faxes.md * KAZOO-5248: amend `make apis` * KAZOO-5248: make apis * KAZOO-5248: use os.path.dirname/basename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #3008
BTW @jamesaimonetti the docs site needs Kazoo's tag in the URL.