Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAZOO-938: Crossbar module list needs to be updated #39

Merged
merged 2 commits into from
May 17, 2013
Merged

KAZOO-938: Crossbar module list needs to be updated #39

merged 2 commits into from
May 17, 2013

Conversation

x974
Copy link
Contributor

@x974 x974 commented May 17, 2013

The list of crossbar module in whistle_apps/apps/crossbar/priv/crossbar.config hasn't been updated in some time, so people have to manually edit it when deploying a new cluster.

This updated list should fix this issue.

KAZOO-938: Crossbar module list needs to be updated
db1555c 
The list of crossbar module in whistle_apps/apps/crossbar/priv/crossbar.config hasn't been updated in some time, so people have to manually edit it when deploying a new cluster.

This updated list should fix this issue.
@ghost ghost assigned k-anderson May 17, 2013
@jamesaimonetti
Copy link
Member

Why #cb_queues? I think that's a typo?

Also, can you constrain the line length to 80 chars? Also, no space between the comma and next module when the line starts with ",". That's our general formatting rule.

KAZOO-938: Crossbar module list needs to be updated
6b8d5a8 
The list of crossbar module in https://github.com/2600hz/kazoo/blob/master/whistle_apps/apps/crossbar/priv/crossbar.config hasn't been updated in some time, so people have to manually edit it when deploying a new cluster.

This list should be up to date now and free of typos (hopefully :P)
@x974
Copy link
Contributor Author

x974 commented May 17, 2013

Yup, that was a typo, sorry about that! Is it OK now?

jamesaimonetti pushed a commit that referenced this pull request May 17, 2013
Merge pull request #39 from x974/master
2bda457 
KAZOO-938: Crossbar module list needs to be updated

Looks good. Merci beaucoup gros!
@jamesaimonetti jamesaimonetti merged commit 2bda457 into 2600hz:master May 17, 2013
jamesaimonetti pushed a commit that referenced this pull request May 18, 2015
@danielfinke
Fixed #39 - DTMF digits are properly handled after TTS module
7b344fd
jamesaimonetti pushed a commit that referenced this pull request May 18, 2015
@danielfinke @jamesaimonetti
Fixed #39 - DTMF digits are properly handled after TTS module
8570b62
jamesaimonetti pushed a commit that referenced this pull request May 18, 2015
@danielfinke @jamesaimonetti
Fixed #39 - DTMF digits are properly handled after TTS module
3de6a7a
jamesaimonetti added a commit that referenced this pull request Sep 11, 2018
@jamesaimonetti
# This is a combination of 56 commits.
8ae498f 
# This is the 1st commit message:

Merge the diff into the current doc and try saving again

cleanup logging

prefer the diff's value (excepting _rev)

# This is the commit message #1:

simplfy doc return

# This is the commit message #2:

only convert to binary if a list of ascii is present

also don't convert kz_json:object() to null if found

update tests accordingly

# This is the commit message #3:

use sets:subtract/2 to find the diff in J1 and J2

# This is the commit message #4:

add ability to merge list of jobjs with strategy fun

# This is the commit message #5:

more diff testing

# This is the commit message #6:

flag ensure_saved as deprecated

# This is the commit message #7:

remove arity-4 export

we can change arity-3 to accept options instead of the updates directly

# This is the commit message #8:

ignore return

# This is the commit message #9:

refactor update_doc to take an options list instead

# This is the commit message #10:

update account docs with update proplist

# This is the commit message #11:

add specs and update type

# This is the commit message #12:

update usage of kz_datamgr:update_doc

# This is the commit message #13:

update uses of update_doc

# This is the commit message #14:

expose paths for properties

also fixes updating the version in the accounts DB

# This is the commit message #15:

expose the base properties being set

# This is the commit message #16:

use a setter

# This is the commit message #17:

expose more paths

# This is the commit message #18:

update uses of ensure_saved to use update_doc

# This is the commit message #19:

fix function call

# This is the commit message #20:

ignore returns

# This is the commit message #21:

less args passed around

# This is the commit message #22:

filter undefined

# This is the commit message #23:

takes a flat proplist

# This is the commit message #24:

match return

# This is the commit message #25:

use the saved version in future contexts

# This is the commit message #26:

just try to delete the doc without opening it

# This is the commit message #27:

handle returns

# This is the commit message #28:

handle return

# This is the commit message #29:

delete the doc directly, handle returns

# This is the commit message #30:

refactor a bit

# This is the commit message #31:

remove unreachable clause

# This is the commit message #32:

update spec

# This is the commit message #33:

expose more paths

# This is the commit message #34:

expose more paths

# This is the commit message #35:

fix specs

# This is the commit message #36:

match on proper return

# This is the commit message #37:

update spec

# This is the commit message #38:

update account docs

# This is the commit message #39:

should save the docs

# This is the commit message #40:

add missing types

# This is the commit message #41:

hackney wants a binary

# This is the commit message #42:

hackney wants a binary

# This is the commit message #43:

more strict checking of design docs

# This is the commit message #44:

update type

# This is the commit message #45:

update usages

# This is the commit message #46:

add announcement for 4.3

# This is the commit message #47:

update spelling

# This is the commit message #48:

fix spelling

# This is the commit message #49:

ref the local fun

# This is the commit message #50:

save the accounts version if not_found

# This is the commit message #51:

return the account db version

# This is the commit message #52:

hide $ from formatter

# This is the commit message #53:

make sure to update the account doc

# This is the commit message #54:

move saving account docs to updates instaed

# This is the commit message #55:

right function name this time
sudomabider pushed a commit to OpenTelecom/kazoo that referenced this pull request Oct 16, 2018
@BorigTheDwarf
Merged in KAZ-346 (pull request 2600hz#39)
1c17383 
Kaz 346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@k-anderson k-anderson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x974 @jamesaimonetti @k-anderson