Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I think we need three layouts :-( [p0] #111

Open
efortuna opened this issue May 2, 2019 · 3 comments
Open

I think we need three layouts :-( [p0] #111

efortuna opened this issue May 2, 2019 · 3 comments

Comments

@efortuna
Copy link
Collaborator

efortuna commented May 2, 2019

The new version of the three column layout may work for the TV (? Might be weird there too), but I think the characters are too small for laptop, and we ARE going to have some laptops/tablets with this game. See picture.
IMG_1085
@efortuna efortuna changed the title I think we need three layouts :-( I think we need three layouts :-( [p0] May 2, 2019
@luigi-rosso
Copy link
Contributor

We caught this on the demo branch too. We’ve maxed it to four characters per row there. We can submit that change separately for master too.

@efortuna
Copy link
Collaborator Author

efortuna commented May 2, 2019

Demo branch (at least what's checked in) is still having the same issue. If you can push the fix to master asap that would be hugely appreciated (I'm trying to lock down our demo code but I wanted the nice fixed layout when runnign on the chromebook! :-P )

@luigi-rosso
Copy link
Contributor

Sorry haven't pushed that in yet as we're still working through some things! I'll submit a pr to master that clamps the character columns in a sec.

This was referenced May 2, 2019
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luigi-rosso @efortuna