Demo Layout for TV #115
Closed
Demo Layout for TV #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change particle size as character widget size changes.
Fixing upgrade/hire tests referenced in #109.
|
ultrawide layout sgtm! |
efortuna
approved these changes
May 3, 2019
| @@ -21,7 +21,8 @@ class TaskListItem extends StatelessWidget { | |||
| // completed (if there is one). | |||
| // This ensures that the BuildContext is still valid after | |||
| // the game completes. | |||
| switch (task.blueprint.miniGame) { | |||
| var game = MiniGame.sphinx; | |||
There was a problem hiding this comment.
this seems not intentional? debugging?
There was a problem hiding this comment.
Oh shoot. Yes we were testing the end modal. Thanks @efortuna
Merged
|
I'm going to close this PR and integrate some of the changes from the ultrawide PR into demo branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another one for the demo branch. It addresses issue #95 and #104, and improves #96. Screenshots are posted in #95.
It adds a checkbox to the About screen that lets you enable a special layout for the TV.
This special/override layout does a few things:
Bumps font, image, icon sizes to make the more legible from afar on the 42 inch screen.
Bumps button heights.
Uses a different layout for the stats.
Centers and limits the width of the chomper minigame.
However, @neurowave and I have been discussing issue #111 this afternoon. We realized there might be an opportunity to move this special layout out of the demo branch and into master, but use different logic to trigger it. Maybe call it the ultrawide layout and only trigger it when the screen width is >= 1920. We didn't want to do this now as we thought the priority would be to get the demo in tip top shape, but like @efortuna states in #111 there are some desktops where this layout might look better (but we're not sure, maybe we wouldn't bump the fonts quite as much). Anyway, we thought we'd start the discussion here.