Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving layout for wide screens. Issue #96. #107

Merged
merged 2 commits into from
May 1, 2019

Conversation

luigi-rosso
Copy link
Contributor

@luigi-rosso luigi-rosso commented May 1, 2019

I made the task columns not go over a certain width (currently corresponds to modal max width). This helps prevent the add task/bug buttons from getting too wide too. We can tweak this further if we want that column to be bigger than the archived tasks one.

One thing I ran into when implementing this was that I was unable to use a the constraints to achieve the layout I wanted, so I resorted to measuring the width, which isn't ideal.

I had originally tried to do it with constraints by using FlexFit.loose and constraining the width of the content. This works in constraining and aligning the columns properly, but the first column doesn't expand to the full remaining width.

Row(children:[ 
   // characters 
   Expanded(...), 

   // active tasks
   Flexible(
      fit: FlexFit.loose, 
      child: ConstrainedBox(...),
   ),

   // archived tasks
   Flexible(
      fit: FlexFit.loose, 
      child: ConstrainedBox(...),
   ),

Looks like this on an iPad Pro:
image

),
_fadeOverlay,
],
return Container(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this container actually do anything? It doesn't like it has any height/width/color settings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oversight, should've been removed! Thanks for catching.

Copy link
Collaborator

@filiph filiph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luigi-rosso luigi-rosso merged commit d71107a into 2d-inc:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants