Fix broken TUN if custom geo file is selected #5834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
While doing #5829, I did not take into account that a sing-box is started for TUN mode. Since the previous implementation does not support srs files, TUN mode was broken if categories that are not in the main repository were used.
Since it doesn't seem to make sense to specify geo and srs sources separately, I converted the checkbox to a list of source types (empty by default).
I thought about leaving the ability to specify geoUrl and srsUrl in the config via json, but no one seems to want that, although it brings additional code that will have to be maintained.
I apologize for having to ask you to review this again