Fix Issue #1, Cleaned up variancechecker function #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting! I'll try testing it out later tonight. |
|
How did it go? |
|
Very clean, but as you can see here, the calculations are off from the desired number. Result on the left is using your code, and the right is the old code. |
|
Alright, fixed the issue. There was a large gap between 9500 and 100000 that gives 0.095 no matter what the number rounded was (For example, 23025 gives 0.095). The current commit should fix that. |
|
@CometS1 Beautiful! You've earned this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified variancechecker to use calculations instead of checks for ease of use, created calculatevariance function for use with variancechecker.