Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: allow tiled wms when singleTile is false and layer is not ca… #4785

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix: allow tiled wms when singleTile is false and layer is not ca… #4785

merged 2 commits into from
Sep 30, 2024

Conversation

nboisteault
Copy link
Member

No description provided.

@nboisteault nboisteault added run end2end If the PR must run end2end tests or not backport release_3_8 labels Sep 24, 2024
@github-actions github-actions bot added this to the 3.9.0 milestone Sep 24, 2024
@mdouchin mdouchin requested a review from rldhont September 25, 2024 07:41
@nboisteault nboisteault force-pushed the tiled_wms branch 2 times, most recently from 87dea8f to 0645148 Compare September 26, 2024 12:00
@nboisteault
Copy link
Member Author

@rldhont ready for review

@nboisteault
Copy link
Member Author

@rldhont I changed https://github.com/3liz/lizmap-web-client/pull/4785/files#diff-bf6e96d0d15dec384eee57764b40c9215472541f9c6b333d202590d5b291c483R96

Is it ok for you?

@nboisteault nboisteault merged commit 9f53372 into 3liz:master Sep 30, 2024
13 checks passed
@nboisteault nboisteault deleted the tiled_wms branch September 30, 2024 10:52
@3liz-bot 3liz-bot mentioned this pull request Sep 30, 2024
Merged
@rldhont rldhont added map viewer javascript Pull requests that update Javascript code labels Sep 30, 2024
@rldhont rldhont mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rldhont rldhont Awaiting requested review from rldhont

Assignees
No one assigned
Labels
backport release_3_8 javascript Pull requests that update Javascript code map viewer run end2end If the PR must run end2end tests or not
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nboisteault @rldhont