Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Lizmap modules infos #4804

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Show Lizmap modules infos #4804

merged 5 commits into from
Sep 30, 2024

Conversation

nworr
Copy link
Contributor

@nworr nworr commented Sep 27, 2024

Funded by 3Liz
image

@github-actions github-actions bot added this to the 3.9.0 milestone Sep 27, 2024
@mdouchin
Copy link
Collaborator

Can you please copy/paste here the list of modules returned by the page ? I would like to identify which ones we should hide (not relevant for the admin)

@Gustry
Copy link
Member

Gustry commented Sep 30, 2024

@mdouchin I think it's the hardcoded list in the PR in lizmap/modules/admin/lib/ModulesInfo/ModulesChecker.php.

I can try to implement it in the JSON metadata, using your branch @nworr

@nworr
Copy link
Contributor Author

nworr commented Sep 30, 2024

module
jelix
jacl2
jacl2db
jcommunity
admin
dataviz
filter
action
dynamicLayers
lizmap
proj4php
view
jacl2db_admin
jauthdb_admin
master_admin

@Gustry
Copy link
Member

Gustry commented Sep 30, 2024

@nworr I have rebased, and work on your branch, to include the JSON as well.

I can confirm, only lizmapdemo is in the output when we do not ask for core modules, which is fine for me.

@Gustry Gustry added the run end2end If the PR must run end2end tests or not label Sep 30, 2024
@Gustry
Copy link
Member

Gustry commented Sep 30, 2024

image

image

@Gustry Gustry marked this pull request as ready for review September 30, 2024 09:47
@Gustry Gustry requested a review from mdouchin September 30, 2024 09:50
@Gustry
Copy link
Member

Gustry commented Sep 30, 2024

I can't ask the review to @nworr as you are the author of the PR.
Can you check it @nworr and @mdouchin ?

@Gustry Gustry merged commit d04cd0e into 3liz:master Sep 30, 2024
13 checks passed
@3liz-bot 3liz-bot mentioned this pull request Sep 30, 2024
Merged
@nworr nworr mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdouchin mdouchin mdouchin approved these changes

Assignees
No one assigned
Labels
administration pages backport release_3_8 run end2end If the PR must run end2end tests or not
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nworr @mdouchin @Gustry