Add default_port option for compatibility with libmemcached.
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libmemcached ignores the default memcached port when hashing via ketama_weighted: http://bazaar.launchpad.net/~tangent-trunk/libmemcached/1.2/view/head:/libmemcached/hosts.cc#L293 To match the behaviour, use `new HashRing(hosts, 'md5', {default_port:11211})`
|
@rcoup Thanks a lot for catching this and providing me with a pull request and a test. |
3rd-Eden
added a commit
that referenced
this pull request
Sep 22, 2014
Add `default_port` option for compatibility with libmemcached.
rcoup
added a commit
to rcoup/node-memcached
that referenced
this pull request
Sep 22, 2014
When using ketama compatibility, utilise the `default_port` option from 3rd-Eden/node-hashring#23
|
It was a complete bugger to track down 😭, thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libmemcached ignores the default memcached port when hashing via ketama_weighted:
http://bazaar.launchpad.net/~tangent-trunk/libmemcached/1.2/view/head:/libmemcached/hosts.cc#L293
So,
['1.1.1.1:11211', '2.2.2.2:11211', '1.1.1.1:11212']builds a an identical continuum to['1.1.1.1', '2.2.2.2', '1.1.1.1:11212']in libmemcached (usingketama_weighted). In node-hashring the port is always hashed, so there is an incompatibility if you specify:11211in your node-hashring server list.To match the libmemcached behaviour, I added a
default_portoption, and if the server port matches the default port it isn't used in the continuum hash. ie: