[THREESCALE-1150] Add option to use only path-based routing #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porueesq
reviewed
May 13, 2019
doc/parameters.md
Outdated
| - `true` or `1` for _true_ | ||
| - `false`, `0` or empty for _false_ | ||
|
|
||
| When this parameter is set to _true_, the gateway will use path-based routing and will not fallback to the default host-based routing. The API request will be routed to the first service that has a matching mapping rule, from the list of services for which the value of the `Host` header of the request matches the _Public Base URL_. |
There was a problem hiding this comment.
Suggested change
| When this parameter is set to _true_, the gateway will use path-based routing and will not fallback to the default host-based routing. The API request will be routed to the first service that has a matching mapping rule, from the list of services for which the value of the `Host` header of the request matches the _Public Base URL_. | |
| When this parameter is set to _true_, the gateway uses path-based routing and does not fallback to the default host-based routing. The API request is routed to the first service that has a matching mapping rule, from the list of services for which the value of the `Host` header of the request matches the _Public Base URL_. |
There was a problem hiding this comment.
Changed 👍
Thanks for the review.
porueesq
approved these changes
May 13, 2019
davidor
force-pushed
the
option-path-routing-only
branch
from
23b4227 to
e991c9b
Compare
eloycoto
reviewed
May 14, 2019
| end) | ||
|
|
||
| it('stores nil in the context even if there is a service for the host', function() | ||
| local service = { id = '1' } |
There was a problem hiding this comment.
A quick comment, shouldn't need to test with more than one service?
There was a problem hiding this comment.
It's not really needed. This module only cares about what the HostBasedFinder and the PathBasedFinder modules return and they just return one service. In those 2 modules we have tests with configurations that have multiple services, so I think we are covered.
While at it, removed the unnecessary checks like the ones related with caching internals that are not related with this functionality. Also, made the second test clearer by making sure that both services return different error codes for the "No mapping rules matched" error.
davidor
force-pushed
the
option-path-routing-only
branch
from
e991c9b to
7e4e6cf
Compare
|
Rebased on top of master to solve conflicts in the changelog. |
eloycoto
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://issues.jboss.org/browse/THREESCALE-1150
This PR adds a new env,
APICAST_PATH_ROUTING_ONLY. When set to true, the gateway will use path-based routing and will not fallback to the default host-based routing, which is what happens when usingAPICAST_PATH_ROUTING.