[THREESCALE-2590] Add matches operation to the Rate Limit policy #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "when conditions are defined" block was incorrectly placed under the "using redis" one.
eloycoto
approved these changes
May 29, 2019
mikz
reviewed
May 29, 2019
| @@ -64,7 +64,7 @@ | |||
| }, | |||
| "op": { | |||
| "type": "string", | |||
| "enum": ["==", "!="] | |||
| "enum": ["==", "!=", "matches"] | |||
There was a problem hiding this comment.
We should describe what is the format of "matches".
Redis is not used in this test. Looks like a copy-paste issue.
davidor
force-pushed
the
edge-limiting-matches-op
branch
from
0b9bf7f to
b1693ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes THREESCALE-2590
Apart from that, I fixed a couple of minor things in the test files that I needed to modify to implement the patch.