Load service configs one by one lazily #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porueesq
reviewed
Jul 22, 2019
porueesq
reviewed
Jul 22, 2019
porueesq
reviewed
Jul 22, 2019
davidor
commented
Jul 22, 2019
eloycoto
reviewed
Jul 23, 2019
| end | ||
|
|
||
| local function parse_resp_body(self, resp_body) | ||
| local json = cjson.decode(resp_body) |
There was a problem hiding this comment.
shouldn't be here a call with pcall to make sure that decode works ok if not return an error message?
There was a problem hiding this comment.
Right. Good idea. I also added a test for it.
| local proxy_configs = json.proxy_configs or {} | ||
|
|
||
| for i=1, #proxy_configs do | ||
| local proxy_config = proxy_configs[i].proxy_config |
There was a problem hiding this comment.
why not use an ipairs here?
There was a problem hiding this comment.
It was like this before, but I don't see why not use ipairs.
Changed 👍
| if self == _M or not self then | ||
| local host = environment | ||
| local m = _M.new() | ||
| local ret, err = m:index(host) | ||
|
|
||
| if not ret then | ||
| return m:call() | ||
| if load_just_for_host then |
There was a problem hiding this comment.
Does not make sense to me to keep the negative condition here, I think that can be something like this:
if ret then
return ret, err
end
if load_just_for_host then
...
I think that makes things more clear.
There was a problem hiding this comment.
You're absolutely right. I've simplified this 👍
porueesq
referenced
this pull request
Jul 24, 2019
davidor
force-pushed
the
load-configs-as-they-are-needed
branch
from
40f9796 to
2001c04
Compare
porueesq
approved these changes
Jul 25, 2019
davidor
force-pushed
the
load-configs-as-they-are-needed
branch
from
2001c04 to
2476642
Compare
davidor
force-pushed
the
load-configs-as-they-are-needed
branch
from
2476642 to
c66dc53
Compare
eloycoto
approved these changes
Jul 29, 2019
Extracts a couple of methods that return endpoints to make this class easier to understand, and also documents the services() function.
davidor
force-pushed
the
load-configs-as-they-are-needed
branch
from
c66dc53 to
26aca49
Compare
|
Fixed conflicts in the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to add service configurations lazily.
This might be useful for users with many services configured. By default, APIcast loads all the services each time it downloads its configuration from the 3scale admin portal. With a large number of services, this could become problematic.
When this option is enabled, the configurations are loaded lazily. APIcast will only load the ones configured for the host specified in the host header of the request.
The option is not enabled by default. It is enabled using the
APICAST_LOAD_SERVICES_WHEN_NEEDEDenv.The PR also includes a couple of commits that clean up a bit the
remote_v2module used in this PR and also adds some comments.