Routing Policy: Fix upstream selector base path #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
force-pushed
the
RoutingIssueFixPath
branch
2 times, most recently
from
45e466c to
7abee1b
Compare
If the URL for the upstream has a path, with the combination of
replace_path feature, the path the will be overwritten, and the expected
behaviour will not work as expected.
Example config:
```
{
"url": "http://echo-api.3scale.net/test/",
"condition": {
"operations": [
{
"match": "path",
"op": "matches",
"value": "/echo/.*|/echo/?"
}
]
},
"replace_path": "{{original_request.path | remove_first: '/echo'}}"
}
```
Calling to
:8080/echo/x?user=1
Without the change will call to `http://echo-api.3scale.net/x?user=1`
With this change the target will be `http://echo-api.3scale.net/test/x?user=1`
Signed-off-by: Eloy Coto <[email protected]>
eloycoto
force-pushed
the
RoutingIssueFixPath
branch
from
7abee1b to
8f4b739
Compare
davidor
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the URL for the upstream has a path, with the combination of
replace_path feature, the path the will be overwritten, and the expected
behaviour will not work as expected.
Example config:
Calling to
:8080/echo/x?user=1
Without the change will call to
http://echo-api.3scale.net/x?user=1With this change, the target will be
http://echo-api.3scale.net/test/x?user=1Signed-off-by: Eloy Coto [email protected]