Routing: Fix issues with invalid metric update on routing policy. #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
force-pushed
the
RoutingIssues
branch
from
460e931 to
a63400f
Compare
gateway/src/apicast/mapping_rule.lua
Outdated
| @@ -123,7 +124,8 @@ function _M.from_proxy_rule(proxy_rule) | |||
| proxy_rule.querystring_parameters, | |||
| proxy_rule.metric_system_name, | |||
| proxy_rule.delta, | |||
| proxy_rule.last | |||
| proxy_rule.last, | |||
| tonumber(proxy_rule.owner_id) | |||
There was a problem hiding this comment.
If you really want to use owner_id here instead of the proposed backend_id, then you will also need owner_type. That's because the proxy rule can belong to a product (owner_type == "Proxy") or to a backend (owner_type == "BackendApi"). In the first case, it should be considered for the match despite owner_id, while in the latter case, only if owner_id matches the one of the routing.
eloycoto
force-pushed
the
RoutingIssues
branch
10 times, most recently
from
b736a59 to
3085a49
Compare
davidor
reviewed
Oct 16, 2019
eloycoto
force-pushed
the
RoutingIssues
branch
5 times, most recently
from
2b34620 to
e91ee50
Compare
|
I've reviewed the latest changes. I think the PR looks good except for this #1125 (comment) I think it's still an issue. |
eloycoto
force-pushed
the
RoutingIssues
branch
from
e91ee50 to
9107aa5
Compare
Due to the changes in APIAP in 3Scale, a service can have multiple backends(using routing policy) and multiple mapping rules can be hit and it creates a bad behaviour around metrics reported to Apisonator. This commit adds a ownership field on routing and mapping rules, where a ownership can be used to filter the mapping rules that you want to report. Here an example: Routing policy: ``` path backend owner ---------------------------------- /foo/bar http://1.1.1.1/ t1 /foo http://2.2.2.2/ t2 ``` Mapping rules: ``` path metric owner ----------------------------------- /foo hits t2 /foo/bar barMetric t1 ``` In this case, due to the request is going to /foo/bar the metric that will be updated will be `barMetric` and it'll use `2.2.2.2` backend, the mapping rules to match will filter by the owner, in this case, t2. Signed-off-by: Eloy Coto <[email protected]>
eloycoto
force-pushed
the
RoutingIssues
branch
from
9107aa5 to
34ac177
Compare
davidor
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes in APIAP in 3Scale, a service can have multiple
backends(using routing policy) and multiple mapping rules can be hit and
it creates a bad behaviour around metrics reported to Apisonator.
This commit adds ownership on routing and mapping rules, where a
ownership can be used to filter the mapping rules that you want to
report. Here an example:
Routing policy:
Mapping rules:
In this case, due to the request is going to /foo/bar the metric that
will be updated will be
barMetricand it'll use2.2.2.2backend, themapping rules to match will filter by the owner, in this case, t2.