SERVICES_FILTER: Fix issues with oidc. #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
force-pushed
the
SERVICES_FILTER
branch
5 times, most recently
from
68668bf to
6e969b9
Compare
davidor
reviewed
Sep 30, 2020
t/apicast-subset-of-services.t
Outdated
| @@ -184,3 +187,83 @@ __DATA__ | |||
| ["yay, api backend\n", "yay, api backend two\n", ""] | |||
| --- error_code eval | |||
| [200, 200, 404] | |||
|
|
|||
|
|
|||
| === TEST 4: Verify OIDC issue | |||
There was a problem hiding this comment.
Can you add the link to the issue here?
The oidc-service mapping is not based on a key, so each time that a service is deleted, the mapping to the given service is broken. With this change, the OIDC config is stored with the service id, so in case that some services are removed, it'll keep it correctly mapped. FIX THREESCALE-6042 Signed-off-by: Eloy Coto <[email protected]>
eloycoto
force-pushed
the
SERVICES_FILTER
branch
from
6e969b9 to
c2c828b
Compare
davidor
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oidc-service mapping is not based on a key, so each time that a
service is deleted, the mapping to the given service is broken.
With this change, the OIDC config is stored with the service id, so in
case that some services are removed, it'll keep it correctly mapped.
FIX THREESCALE-6042
Missing unit test
Signed-off-by: Eloy Coto [email protected]