Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase size of dictionaries used by the batching policy #1231

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

davidor
Copy link
Contributor

@davidor davidor commented Oct 8, 2020

I'm running some benchmarks with a large number of products, services, metrics, etc. and 1MB for the dictionaries used by the batching policy is not enough. I've seen the free space go to 0 using Prometheus.

For the particular use case that I'm trying ~12MB seems to be the minimum space required. I've defined 20 to have some margin.

@davidor davidor requested a review from a team as a code owner October 8, 2020 12:29
@davidor davidor requested a review from eloycoto October 8, 2020 12:30
@davidor davidor force-pushed the increase-size-batching-dicts branch from 5b6d55c to b7880cc Compare October 8, 2020 12:38

Verified

This commit was signed with the committer’s verified signature. The key has expired.
davidor David Ortiz
In some use cases that we are trying with a large number of products,
services, metrics, etc., 1MB for each is not enough.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
davidor David Ortiz
@davidor davidor force-pushed the increase-size-batching-dicts branch from b7880cc to 39349b4 Compare October 8, 2020 13:52
@davidor davidor merged commit 1915775 into master Oct 8, 2020
@davidor davidor deleted the increase-size-batching-dicts branch October 8, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants