Increase size of dictionaries used by the batching policy #1231
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
force-pushed
the
increase-size-batching-dicts
branch
from
5b6d55c to
b7880cc
Compare
eloycoto
approved these changes
Oct 8, 2020
In some use cases that we are trying with a large number of products, services, metrics, etc., 1MB for each is not enough.
davidor
force-pushed
the
increase-size-batching-dicts
branch
from
b7880cc to
39349b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running some benchmarks with a large number of products, services, metrics, etc. and 1MB for the dictionaries used by the batching policy is not enough. I've seen the free space go to 0 using Prometheus.
For the particular use case that I'm trying ~12MB seems to be the minimum space required. I've defined 20 to have some margin.