Policy: MTLS with trusted store and verify #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eloycoto
commented
Jun 16, 2021
eloycoto
commented
For some reason I had issues when using ffi.metatypes to interact with the ffi interface. With this change,the store will not use ffi.metatype and it'll send the object natively to the ffi functions. Other option was to use self.cdata, but it's not clear at all, and this makes more sense. Inspired in the work made by https://github.com/fffonion/lua-resty-openssl Signed-off-by: Eloy Coto <[email protected]>
eloycoto
force-pushed
the
THREESCALE-7099
branch
from
094ad1f to
67e8cd5
Compare
davidor
reviewed
Jun 18, 2021
| valid = true | ||
| store:add_cert(cert) | ||
| else | ||
| ngx.log(ngx.INFO, "cannot load certificate, err: ", err) |
| end | ||
|
|
||
| store = nil | ||
| return |
|
|
||
| it("ca_store is nil if no certificates", function() | ||
| local config = { | ||
| certificate = "XXXX", |
There was a problem hiding this comment.
You could extract this string to a variable accessible from all the tests and reuse it everywhere.
When using upstream_mtls policy, the policy only sends the client certificates but does not verify the connection. Therefore, the policy name is not honouring what it did. A new x509_store will be created with this change, and it'll be used to verify the SSL_context. This change will use some FFI functions that are part of apicast-nginx-module[0] Fix THREESCALE-7099 [0] https://github.com/3scale/apicast-nginx-module Signed-off-by: Eloy Coto <[email protected]>
Signed-off-by: Eloy Coto <[email protected]>
eloycoto
force-pushed
the
THREESCALE-7099
branch
from
67e8cd5 to
5121c97
Compare
davidor
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.