TEST: Fix Uptream MTLs policy integration test #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
force-pushed
the
THREESCALE-768
branch
from
f6be064 to
277fd19
Compare
unleashed
reviewed
Aug 11, 2021
| @@ -575,3 +575,72 @@ ssl_client_i_dn: CN=localhost,OU=APIcast,O=3scale | |||
| --- error_code: 200 | |||
| --- no_error_log | |||
| [error] | |||
|
|
|||
|
|
|||
| === TEST 8: MTLS policy with correct CA certificate, but invalid host | |||
There was a problem hiding this comment.
Where are you specifying the invalid host here?
There was a problem hiding this comment.
Hi,
Just here:
TLS certificates are localhost, but host we use the host test
Regards
There was a problem hiding this comment.
Ok, can we add a comment to the test adding this information, ie. the certificates are set up for localhost but here we will use a different hostname?
eloycoto
force-pushed
the
THREESCALE-768
branch
2 times, most recently
from
9bacaa8 to
8370b52
Compare
unleashed
approved these changes
Aug 12, 2021
When using invalid host, the ngx_ssl_host was not used, so the verify was working when it shouldn't. This PR is part of THREESCALE-768 Signed-off-by: Eloy Coto <[email protected]>
eloycoto
force-pushed
the
THREESCALE-768
branch
from
8370b52 to
79418ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using invalid host, the ngx_ssl_host was not used, so the verify
was working when it shouldn't.
This PR is part of THREESCALE-768
Signed-off-by: Eloy Coto [email protected]