Routing: Fix encoding. #1297
Merged
Routing: Fix encoding. #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unleashed
approved these changes
Aug 16, 2021
When using encoding, some characters got encoded a few times, so the upstream request was not correct. Is impossible to get it 100% perfect, because some chars (`?/#`) are hard to get it right when using ngx.var.uri, but we need to use ngx.var.uri. After discussing it with support/product, this is the best way to handle it. Reported by [email protected] Fix: https://issues.redhat.com/browse/THREESCALE-5117 Signed-off-by: Eloy Coto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using encoding, some characters got encoded a few times, so the
upstream request was not correct.
Is impossible to get it 100% perfect, because some chars (
?/#) arehard to get it right when using ngx.var.uri, but we need to use
ngx.var.uri.
After discussing it with support/product, this is the best way to handle
it.
Reported by [email protected]
Fix: https://issues.redhat.com/browse/THREESCALE-5117
Signed-off-by: Eloy Coto [email protected]