OIDC: fix issue on remote v2. #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unleashed
reviewed
Sep 1, 2021
| @@ -562,5 +565,62 @@ UwIDAQAB | |||
| assert.is_nil(config) | |||
| assert.equals('Expected object key string but found invalid token at character 3', err) | |||
| end) | |||
|
|
|||
| it('treturns configuration with oidc config complete', function() | |||
eloycoto
force-pushed
the
OIDCFilterIssueb
branch
from
695512a to
aaa2e3d
Compare
unleashed
approved these changes
Sep 1, 2021
This is a second patch, and it's related to PR #1304. When using remotev2 loader, the config.oidc is created in there, and there is also a caching mechanism for OIDC[0], so we need to append the service_id and send a valid table in case of non OIDC setup. Because this oidc is cached, we also do a deepcopy, to avoid to use always the same reference, so the config.oidc[i].service_id is always different and we didn't get a invalid filtering. This is only failing when using APICAST_SERVICE_LIST [0] Commit: 720cd99 Related to: THREESCALE-6042 Signed-off-by: Eloy Coto <[email protected]>
eloycoto
force-pushed
the
OIDCFilterIssueb
branch
from
aaa2e3d to
1f4d17f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second patch, and it's related to PR #1304.
When using remotev2 loader, the config.oidc is created in there, and
there is also a caching mechanism for OIDC[0], so we need to append the
service_id and send a valid table in case of non OIDC setup.
Because this oidc is cached, we also do a deepcopy, to avoid to use
always the same reference, so the config.oidc[i].service_id is always
different and we didn't get a invalid filtering.
This is only failing when using APICAST_SERVICE_LIST
[0] Commit: 720cd99
Related to: THREESCALE-6042
Signed-off-by: Eloy Coto [email protected]