Docker compose up instead of docker compose run #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
changed the title
eguzki
changed the title
eguzki
force-pushed
the
docker-compose-up-instead-of-run
branch
from
133d3fd to
cef0721
Compare
|
LGTM! |
tkan145
approved these changes
Feb 5, 2024
eguzki
force-pushed
the
docker-compose-up-instead-of-run
branch
from
cef0721 to
8c0713a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Dev environments use
docker compose upinstead ofdocker compose run.I was confused when using
docker compose runthat when listing the containers running in the project, apicast was not there. I learned it is because we were usingdocker compose run. Then I learned thatruncommand is meant fro running "one-off" task. More appropriate for running tests. Furthermore, it does not respect some service configuration like command or ports.