Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configuration] allow locking service configuration version #293

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

mikz
Copy link
Contributor

@mikz mikz commented Mar 13, 2017

by setting APICAST_SERVICE_${ID}_CONFIGURATION_VERSION environment
variable to some version it is going to be used to lock to that version

depends on #292

no ideas how to document this, ideas ? @vramosp @3scale/support @jcechace ?

@mayorova
Copy link
Contributor

Just a thought – CONFIGURATION is so long, we could use CONF instead :)
But probably it's too late, as we already have a lot of other env vars using CONFIGURATION, so we probably don't want to change them all.

@mikz
Copy link
Contributor Author

mikz commented Mar 13, 2017

I'd rather not use abbreviations as they don't really explain it fully. It would matter in cases which you repeatedly type, but this is not that case IMO. Kind of write-once situation.

@andrewdavidmackenzie
Copy link
Member

Is this needed for ER5? (someone asking for it?)
Or just a general improvement in the same timeframe?

@mikz
Copy link
Contributor Author

mikz commented Mar 13, 2017

@andrewdavidmackenzie it is linked from private Jira ticket.

And a missing feature we agreed the gateway should have before implementing the v2 configuration loading.

@mikz mikz added the B-current label Mar 13, 2017
@mikz mikz force-pushed the lock-service-version branch 2 times, most recently from dbd6034 to cd37439 Compare March 14, 2017 11:49

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
by setting `APICAST_SERVICE_${ID}_CONFIGURATION_VERSION` environment
variable to some version it is going to be used to lock to that version

depends on #292
@mikz mikz force-pushed the lock-service-version branch from cd37439 to c68f2cd Compare March 14, 2017 11:53
@octobot
Copy link

octobot commented Mar 14, 2017

Proselint found issues

doc/parameters.md

Line Message Severity

Spell Checker found issues

doc/parameters.md

Line Typo
3 APIcast v2 has a number of parameters co
3 ariables) that can modify the behavior of the gateway. The following
5 e that when deploying APIcast v2 with OpenShift, some of thee
15 Default: **stderr**
17 or more information. The file pathcan be either absolute, or relati
21 nfo
21 warn
37 Default: "apicast"
68 Values: a number > **60**
69 Default: 0
71 r. The value should be set to 0 or more than 60. For example,
71 ould be set to 0 or more than 60. For example, if `APICAST_CON
71 ONFIGURATION_CACHE` is set to 120, the gateway will reload the
71 eload the configuration every 2 minutes (120 seconds).
71 onfiguration every 2 minutes (120 seconds).
75 Default: "127.0.0.1"
77 ning Redis instance for OAuth 2.0 flow. REDIS_HOST parameter
81 Default: 6379
83 ning Redis instance for OAuth 2.0 flow. REDIS_PORT parameter
87 pty, the DNS resolver will be autodiscovered.
134 Setting it to particual version will make it not auto

Generated by 🚫 Danger

@mikz mikz merged commit 1c04f6a into master Mar 14, 2017
@mikz mikz deleted the lock-service-version branch March 14, 2017 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants