Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove request_unbuffered policy #47

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Remove request_unbuffered policy #47

merged 2 commits into from
Feb 28, 2025

Conversation

tkan145
Copy link
Contributor

@tkan145 tkan145 commented Feb 28, 2025

APIcast comes with a new policy called request_unbuffered which allows requests to bypass Nginx's default buffering mechanism and may pose a threat to our cloud hosted APIcast. So let's remove it from the list

@tkan145 tkan145 requested a review from slopezz February 28, 2025 07:12
@slopezz
Copy link
Member

slopezz commented Feb 28, 2025

Hi @tkan145 , the mapping-service test (even before your addition) was failing because of https://github.com/3scale/apicast-cloud-hosted/actions/runs/13583194430/job/37972741260 :

ERROR: ...t/src/lua_modules/share/lua/5.1/apicast/policy_chain.lua:61: module "apicast.policy.load_configuration" could not be loaded: ...pp-root/src/lua_modules/share/lua/5.1/resty/oidc/jwk.lua:4: module 'resty.openssl.pkey' not found:No LuaRocks module found for resty.openssl.pkey

I added a commit 1d7be38 that fixes the mapping-service tests by adding latest version of a new dependency lua-resty-openssl 1.5.2 , but TBH I don't know if the addition of this new dependency has any possible (negative) impact, can you please validate?

cc @roivaz given your experience with apicast-cloud-hosted, do you have anything to say?

@roivaz
Copy link
Contributor

roivaz commented Feb 28, 2025

I don't see a problem with it so let's go ahead and merge this. Any issue, we should catch while testing in staging.

@slopezz slopezz merged commit 53730c3 into master Feb 28, 2025
2 checks passed
@slopezz slopezz deleted the 3scale-2.15 branch February 28, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants