THREESCALE-10212: Fix account approved email template #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlledom
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a bug introduced by https://github.com/3scale/porta/pull/3001/files#diff-1c5334d368e3ebaf8349ca1d8407e2e694c6d9b54ff062dd728305c900ea4e1e
We renamed all internal invocations of
.domainbecause this method had been deprecated. However, in this case it's a Liquid drop, it should never have been changed, but we missed this.Which issue(s) this PR fixes
https://issues.redhat.com/browse/THREESCALE-10212
Verification steps
Ensure that when the account is approved, the email is sent correctly.
Special notes for your reviewer: