-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preTransmission(), postTransmission() for half-duplex #44
Conversation
Interested in the PR. Please fix conflicts and resubmit. Thanks. |
Merged with master and resolved conflicts. |
Set pre-transmission callback function. | ||
|
||
This function gets called just before a modbus message is sent over serial. | ||
Typical usage of this callback is to enable an RS485 transcieiver's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: "transcieiver's"
- ...RS485 transcieiver's
+ ...RS485 transceiver's
Thanks for the PR, though I think after I incorporated #43, it introduced new conflicts. I've marked up the PR with minor edits (spelling, capitalization, spacing, & convention). If you'll incorporate these and fix the merge conflict, I'm ready to merge. |
@kintel it occurred to me that we should include a simple example showing off the half-duplex feature. Do you have a simple bare-bones example to include? |
@4-20ma I agree that an example would be nice. I can clean up one of my test sketches and submit that as a separate PR. Thanks for being thorough btw. - it really helps knowing that someone actually read the code :) |
LGTM |
I look forward to a simplified example that shows off how to use the half-duplex feature. Thanks for implementing. Travis CI is now implemented (compiles each example included in |
This is a suggested API change to address dealing with RS-485 transceivers in half duplex mode (Issue #33).
I'm not married to this particular way of solving it, but it's tested to work on my end.