Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GGFE-48] 슬롯 스타일 적용 #826

Merged
merged 8 commits into from
Jun 19, 2023

Conversation

42sungwook
Copy link
Contributor

📌 개요

  • match slot 스타일 적용

💻 작업사항

  • 메뉴얼, 리로딩 버튼을 라디오 버튼 윗쪽으로 위치 수정
  • status가 mytable일 때 로직 수정. (신청한 모드가 아닌 다른 모드일 때 색만 초록색, 버튼 클릭 불가)
  • 슬롯 색 변경

✅ 변경로직

Copy link
Contributor

@PHJoon PHJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

매치보드 라디오 버튼이랑 매치 슬롯 색상 예쁘게 잘 적용됐습니다!! 코멘트 남긴 부분은 이미 알고 계시다고 하니 그부분만 수정되면 문제 없는 듯 합니다. 랭크슬롯 보라색도 보다보니 저는 괜찮은 거 같네요. 고생하셨습니다!! 👍

open: radioMode === 'RANK' ? styles.rank : styles.normal,
match: radioMode === 'RANK' ? styles.rank : styles.normal,
close:
event === 'match' && match[0].startTime === startTime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match 3개까지 잡을 수 있어서 match리스트에 있는 애들 다 비교하는 식으로 바꿔야 할 듯 합니다! Both 3개 등록했더니 1개만 초록색이고 나머지 두개는 close 2/2로 뜹니다.

}

&.disabled {
background: linear-gradient(to bottom, $gray, rgba(217, 217, 217, 0.6));
background: linear-gradient(to bottom, #636671, #424550);
cursor: default;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 분들 의견도 들어봐야하는데, 저는 disabled일 때는 cursor: not-allowed 해도 괜찮을 거 같아요.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미 지난 슬롯이기 때문에 클릭이 안된다는 것을 확실히 표현하기 위해서라면 cursor: not-allowed로 하는것도 좋은 생각인 것 같아요

opacity: 0.7;
pointer-events: none;
animation: spin 1s infinite;
cursor: not-allowed;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리로드했을 때 cursor: not-allowed가 적용 안되는 거 같은데 왜 적용안되는지 이유를 모르겠네요 ㅠ

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

찾아보니까 pointer-events가 none이기 때문에 cursor 역시 적용이 안되는 것 같네여 (참고 : twbs/bootstrap#16088) 참고 링크에 나온대로 pointers-events: all로 수정해주니까 cursor: not-allowed가 적용되더라구요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 감사합니다 disabled 슬롯은 cursor: not-allowed 적용시켰어요

Copy link
Contributor

@PHJoon PHJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석부분 코멘트 달아놨습니다!

100% {
transform: rotate(360deg);
}
}
// .title {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 주석 삭제해도 될 듯 합니다!

Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업내용 확인했습니다! 화면에 표시되는 자기 슬롯 중에서 현재 radioMode에서 버튼 눌러서 취소할 수 있는 슬롯에만 🙋 이 이모지 떠서 편한 것 같아요 ㅎㅎ 👍 수고하셨습니당

Copy link
Contributor

@parksangmin1543 parksangmin1543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

슬롯스타일 확인했습니다. 취소도 잘되네요

@42sungwook 42sungwook merged commit 2365dea into GGFE-00/Feat/api-refactoring Jun 19, 2023
@42sungwook 42sungwook deleted the GGFE-48-Style-Match-Slot branch June 19, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants