Remove default parameters from interpreters, fixes #449

47degrees · Apr 15, 2020 · 910a024 · 910a024
1 parent 439b411
commit 910a024
Show file tree

Hide file tree

Showing 12 changed files with 92 additions and 82 deletions.
diff --git a/github4s/src/main/scala/github4s/algebras/Repositories.scala b/github4s/src/main/scala/github4s/algebras/Repositories.scala
@@ -117,6 +117,7 @@ trait Repositories[F[_]] {
    * @param branch the branch name (defaults to the repository's default branch)
    * @param committer object containing information about the committer (filled in with authenticated user information if omitted)
    * @param author object containing information about the author (filled in with committer information if omitted)
+   * @param headers optional user headers to include in the request
    * @return GHResponse[WriteFileResponse] with details about the content created and the commit
    */
   def createFile(
@@ -143,6 +144,7 @@ trait Repositories[F[_]] {
    * @param branch the branch name (defaults to the repository's default branch)
    * @param committer object containing information about the committer (filled in with authenticated user information if omitted)
    * @param author object containing information about the author (filled in with committer information if omitted)
+   * @param headers optional user headers to include in the request
    * @return GHResponse[WriteFileResponse] with details about the content updated and the commit
    */
   def updateFile(
@@ -169,6 +171,7 @@ trait Repositories[F[_]] {
    * @param branch the branch name (defaults to the repository's default branch)
    * @param committer object containing information about the committer (filled in with authenticated user information if omitted)
    * @param author object containing information about the author (filled in with committer information if omitted)
+   * @param headers optional user headers to include in the request
    * @return GHResponse[WriteFileResponse] with no content and details about the commit which was added.
    */
   def deleteFile(

diff --git a/github4s/src/main/scala/github4s/interpreters/ActivitiesInterpreter.scala b/github4s/src/main/scala/github4s/interpreters/ActivitiesInterpreter.scala
@@ -32,7 +32,7 @@ class ActivitiesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: O
       id: Int,
       subscribed: Boolean,
       ignored: Boolean,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Subscription]] =
     client.put[SubscriptionRequest, Subscription](
       accessToken = accessToken,
@@ -46,7 +46,7 @@ class ActivitiesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: O
       repo: String,
       timeline: Boolean,
       pagination: Option[Pagination],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[List[Stargazer]]] =
     client.get[List[Stargazer]](
       accessToken,
@@ -61,7 +61,7 @@ class ActivitiesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: O
       sort: Option[String],
       direction: Option[String],
       pagination: Option[Pagination],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[List[StarredRepository]]] =
     client.get[List[StarredRepository]](
       accessToken,

diff --git a/github4s/src/main/scala/github4s/interpreters/AuthInterpreter.scala b/github4s/src/main/scala/github4s/interpreters/AuthInterpreter.scala
@@ -38,7 +38,7 @@ class AuthInterpreter[F[_]: Applicative](
       note: String,
       client_id: String,
       client_secret: String,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Authorization]] =
     client.postAuth[NewAuthRequest, Authorization](
       method = "authorizations",
@@ -71,7 +71,7 @@ class AuthInterpreter[F[_]: Applicative](
       code: String,
       redirect_uri: String,
       state: String,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[OAuthToken]] =
     client.postOAuth[NewOAuthRequest, OAuthToken](
       url = client.config.accessTokenUrl,

diff --git a/github4s/src/main/scala/github4s/interpreters/GistsInterpreter.scala b/github4s/src/main/scala/github4s/interpreters/GistsInterpreter.scala
@@ -30,7 +30,7 @@ class GistsInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Option
       description: String,
       public: Boolean,
       files: Map[String, GistFile],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Gist]] =
     client.post[NewGistRequest, Gist](
       accessToken,
@@ -42,7 +42,7 @@ class GistsInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Option
   override def getGist(
       gistId: String,
       sha: Option[String],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Gist]] =
     client.get[Gist](
       accessToken,
@@ -54,7 +54,7 @@ class GistsInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Option
       gistId: String,
       description: String,
       files: Map[String, Option[EditGistFile]],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Gist]] =
     client.patch[EditGistRequest, Gist](
       accessToken,

diff --git a/github4s/src/main/scala/github4s/interpreters/GitDataInterpreter.scala b/github4s/src/main/scala/github4s/interpreters/GitDataInterpreter.scala
@@ -30,8 +30,8 @@ class GitDataInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Opti
       owner: String,
       repo: String,
       ref: String,
-      pagination: Option[Pagination] = None,
-      headers: Map[String, String] = Map()
+      pagination: Option[Pagination],
+      headers: Map[String, String]
   ): F[GHResponse[NonEmptyList[Ref]]] =
     client.get[NonEmptyList[Ref]](
       accessToken,
@@ -45,7 +45,7 @@ class GitDataInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Opti
       repo: String,
       ref: String,
       sha: String,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Ref]] =
     client.post[CreateReferenceRequest, Ref](
       accessToken,
@@ -60,7 +60,7 @@ class GitDataInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Opti
       ref: String,
       sha: String,
       force: Boolean,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Ref]] =
     client.patch[UpdateReferenceRequest, Ref](
       accessToken,
@@ -73,7 +73,7 @@ class GitDataInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Opti
       owner: String,
       repo: String,
       sha: String,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[RefCommit]] =
     client.get[RefCommit](accessToken, s"repos/$owner/$repo/git/commits/$sha", headers)
 
@@ -84,7 +84,7 @@ class GitDataInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Opti
       tree: String,
       parents: List[String],
       author: Option[RefAuthor],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[RefCommit]] =
     client.post[NewCommitRequest, RefCommit](
       accessToken,
@@ -98,7 +98,7 @@ class GitDataInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Opti
       repo: String,
       content: String,
       encoding: Option[String],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[RefInfo]] =
     client.post[NewBlobRequest, RefInfo](
       accessToken,
@@ -112,7 +112,7 @@ class GitDataInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Opti
       repo: String,
       sha: String,
       recursive: Boolean,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[TreeResult]] =
     client.get[TreeResult](
       accessToken,
@@ -126,7 +126,7 @@ class GitDataInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Opti
       repo: String,
       baseTree: Option[String],
       treeDataList: List[TreeData],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[TreeResult]] =
     client.post[NewTreeRequest, TreeResult](
       accessToken,
@@ -143,7 +143,7 @@ class GitDataInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Opti
       objectSha: String,
       objectType: String,
       author: Option[RefAuthor],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Tag]] =
     client.post[NewTagRequest, Tag](
       accessToken,

diff --git a/github4s/src/main/scala/github4s/interpreters/IssuesInterpreter.scala b/github4s/src/main/scala/github4s/interpreters/IssuesInterpreter.scala
@@ -32,8 +32,8 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
   override def listIssues(
       owner: String,
       repo: String,
-      pagination: Option[Pagination] = None,
-      headers: Map[String, String] = Map()
+      pagination: Option[Pagination],
+      headers: Map[String, String]
   ): F[GHResponse[List[Issue]]] =
     client
       .get[List[Issue]](accessToken, s"repos/$owner/$repo/issues", headers, pagination = pagination)
@@ -42,14 +42,14 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       owner: String,
       repo: String,
       number: Int,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Issue]] =
     client.get[Issue](accessToken, s"repos/$owner/$repo/issues/$number", headers)
 
   override def searchIssues(
       query: String,
       searchParams: List[SearchParam],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[SearchIssuesResult]] =
     client.get[SearchIssuesResult](
       accessToken = accessToken,
@@ -66,7 +66,7 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       milestone: Option[Int],
       labels: List[String],
       assignees: List[String],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Issue]] =
     client.post[NewIssueRequest, Issue](
       accessToken,
@@ -85,7 +85,7 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       milestone: Option[Int],
       labels: List[String],
       assignees: List[String],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Issue]] =
     client.patch[EditIssueRequest, Issue](
       accessToken,
@@ -98,8 +98,8 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       owner: String,
       repo: String,
       number: Int,
-      pagination: Option[Pagination] = None,
-      headers: Map[String, String] = Map()
+      pagination: Option[Pagination],
+      headers: Map[String, String]
   ): F[GHResponse[List[Comment]]] =
     client
       .get[List[Comment]](
@@ -114,7 +114,7 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       repo: String,
       number: Int,
       body: String,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Comment]] =
     client.post[CommentData, Comment](
       accessToken,
@@ -128,7 +128,7 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       repo: String,
       id: Int,
       body: String,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Comment]] =
     client
       .patch[CommentData, Comment](
@@ -142,15 +142,15 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       owner: String,
       repo: String,
       id: Int,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Unit]] =
     client.delete(accessToken, s"repos/$owner/$repo/issues/comments/$id", headers)
 
   override def listLabelsRepository(
       owner: String,
       repo: String,
-      pagination: Option[Pagination] = None,
-      headers: Map[String, String] = Map()
+      pagination: Option[Pagination],
+      headers: Map[String, String]
   ): F[GHResponse[List[Label]]] =
     client.get[List[Label]](
       accessToken,
@@ -163,8 +163,8 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       owner: String,
       repo: String,
       number: Int,
-      pagination: Option[Pagination] = None,
-      headers: Map[String, String] = Map()
+      pagination: Option[Pagination],
+      headers: Map[String, String]
   ): F[GHResponse[List[Label]]] =
     client.get[List[Label]](
       accessToken,
@@ -178,7 +178,7 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       repo: String,
       number: Int,
       labels: List[String],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[List[Label]]] =
     client.post[List[String], List[Label]](
       accessToken,
@@ -192,7 +192,7 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       repo: String,
       number: Int,
       label: String,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[List[Label]]] =
     client.deleteWithResponse[List[Label]](
       accessToken,
@@ -203,8 +203,8 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
   override def listAvailableAssignees(
       owner: String,
       repo: String,
-      pagination: Option[Pagination] = None,
-      headers: Map[String, String] = Map()
+      pagination: Option[Pagination],
+      headers: Map[String, String]
   ): F[GHResponse[List[User]]] =
     client.get[List[User]](
       accessToken,
@@ -219,8 +219,8 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       state: Option[String],
       sort: Option[String],
       direction: Option[String],
-      pagination: Option[Pagination] = None,
-      headers: Map[String, String] = Map()
+      pagination: Option[Pagination],
+      headers: Map[String, String]
   ): F[GHResponse[List[Milestone]]] =
     client.get[List[Milestone]](
       accessToken,
@@ -238,7 +238,7 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       state: Option[String],
       description: Option[String],
       due_on: Option[ZonedDateTime],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Milestone]] =
     client.post[MilestoneData, Milestone](
       accessToken,
@@ -251,7 +251,7 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       owner: String,
       repo: String,
       number: Int,
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Milestone]] =
     client.get[Milestone](accessToken, s"repos/$owner/$repo/milestones/$number", headers)
 
@@ -263,7 +263,7 @@ class IssuesInterpreter[F[_]](implicit client: HttpClient[F], accessToken: Optio
       state: Option[String],
       description: Option[String],
       due_on: Option[ZonedDateTime],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[Milestone]] = client.patch[MilestoneData, Milestone](
     accessToken,
     s"repos/$owner/$repo/milestones/$milestone_number",

diff --git a/github4s/src/main/scala/github4s/interpreters/OrganizationsInterpreter.scala b/github4s/src/main/scala/github4s/interpreters/OrganizationsInterpreter.scala
@@ -30,7 +30,7 @@ class OrganizationsInterpreter[F[_]](implicit client: HttpClient[F], accessToken
       filter: Option[String],
       role: Option[String],
       pagination: Option[Pagination],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[List[User]]] =
     client.get[List[User]](
       accessToken,
@@ -47,7 +47,7 @@ class OrganizationsInterpreter[F[_]](implicit client: HttpClient[F], accessToken
       org: String,
       filter: Option[String],
       pagination: Option[Pagination],
-      headers: Map[String, String] = Map()
+      headers: Map[String, String]
   ): F[GHResponse[List[User]]] =
     client.get[List[User]](
       accessToken,

diff --git a/github4s/src/main/scala/github4s/interpreters/ProjectsInterpreter.scala b/github4s/src/main/scala/github4s/interpreters/ProjectsInterpreter.scala
@@ -30,8 +30,8 @@ class ProjectsInterpreter[F[_]](
   override def listProjects(
       org: String,
       state: Option[String],
-      pagination: Option[Pagination] = None,
-      headers: Map[String, String] = Map()
+      pagination: Option[Pagination],
+      headers: Map[String, String]
   ): F[GHResponse[List[Project]]] =
     client.get[List[Project]](
       accessToken,