New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower code coverage threshold #349

Closed

BenFradet opened this issue Feb 24, 2020 · 1 comment

Contributor

BenFradet commented Feb 24, 2020

Without access to the token (e.g. with scala-steward), the code coverage falls below 80% (77.74% to be precise) and the CI fails.

e.g. https://travis-ci.org/47deg/github4s/jobs/653257784#L1057

We could lower the threshold to 75% so that external PRs succeed CI.

Member

cb372 commented Feb 24, 2020

That sounds reasonable. I have to say, on most of our repos the code coverage checker seems to cause more trouble than it's worth.

BenFradet added a commit that referenced this issue


          Lower the minimum code coverage threshold to 75%, fixes #349

3c32d83

rafaparadela closed this as completed in

ab79610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment