Made request success check consistent between scala and scala js #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 88.14% 88.16% +0.02%
==========================================
Files 36 36
Lines 506 507 +1
Branches 3 3
==========================================
+ Hits 446 447 +1
Misses 60 60
Continue to review full report at Codecov.
|
fedefernandez
approved these changes
May 2, 2017
juanpedromoreno
approved these changes
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conforms to scalaj's way of checking that a request has succeeded and avoid the fact that you could have a 3xx (hopefully that's not something that github returns) that succeeds with scala js but fails in the jvm.