Abstract away from cats-effect IO #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenFradet
changed the title
|
Could you please have a look @juanpedromoreno @fedefernandez ? |
fedefernandez
approved these changes
Jul 9, 2018
|
👍 |
kubukoz
reviewed
Jul 9, 2018
| fromFuture(runMap[A, F](rb, mapResponse)) | ||
|
|
||
| /** Taken from Http4s **/ | ||
| private def fromFuture[A](future: Eval[Future[A]])(implicit ec: ExecutionContext): F[A] = |
There was a problem hiding this comment.
Note that there was an issue about having this in cats-effect. Although it'd take a => Future[A], but that's a minor detail. Note that the suggested implementation would short-circuit in case of completed futures (wouldn't call async if the future was Future.successful or Future.failed): typelevel/cats-effect#199 (comment)
There was a problem hiding this comment.
The problem is that the reference implementation uses TrampolineEC and I didn't feel like copying that over too.
just understood what you meant, I'll see what we can change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #213