Take into account that commit authors may be null #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users don't properly configure their git email to be the same as their GitHub email, thus GitHub can't figure out which author (on GitHub) a commit has. I've modified Commit and its decoder to take this into account adding `Option` around the fields that can be null.
|
@raulraja @rafaparadela plz take a look. |
Current coverage is 86.30%@@ master #28 diff @@
==========================================
Files 14 14
Lines 219 219
Methods 217 217
Messages 0 0
Branches 2 2
==========================================
Hits 189 189
Misses 30 30
Partials 0 0
|
ghost
mentioned this pull request
|
LGTM! |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users don't properly configure their git email to be the same as
their GitHub email, thus GitHub can't figure out which author (on
GitHub) a commit has. I've modified Commit and its decoder to take this
into account adding
Optionaround the fields that can be null.