Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP - Upgrades Libraries #32

Merged
merged 4 commits into from
Oct 12, 2016
Merged

Conversation

juanpedromoreno
Copy link
Member

This PR upgrades the library in order to use the latest versions of cats and circe. Additionally, some parts of the existing architecture have been changed to accomplish this work.

After this PR is merged and the new version released, this issue at scala-exercises scala-exercises/scala-exercises#597 can be completed.

Please, @rafaparadela @raulraja could you review? Thanks!

Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanpedromoreno juanpedromoreno force-pushed the jp-upgrade-latest-cats-version branch from e3e7b19 to 7f056f8 Compare October 12, 2016 13:53
@codecov-io
Copy link

codecov-io commented Oct 12, 2016

Current coverage is 85.59% (diff: 79.16%)

Merging #32 into master will decrease coverage by 1.19%

@@             master        #32   diff @@
==========================================
  Files            14         14          
  Lines           227        236     +9   
  Methods         225        234     +9   
  Messages          0          0          
  Branches          2          2          
==========================================
+ Hits            197        202     +5   
- Misses           30         34     +4   
  Partials          0          0          

Powered by Codecov. Last update 5ba514a...7f056f8

@juanpedromoreno juanpedromoreno merged commit b4f6c15 into master Oct 12, 2016
@juanpedromoreno juanpedromoreno deleted the jp-upgrade-latest-cats-version branch October 12, 2016 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants