Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes oauth/access_token Interpreter #509

Merged
merged 3 commits into from
Jun 8, 2020
Merged

Conversation

juanpedromoreno
Copy link
Member

This PR fixes the oauth/access_token.

Essentially, the POST information needs to be passed by URL parameters, instead of in the body, as you can see in this section.

@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #509 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
+ Coverage   90.37%   90.45%   +0.07%     
==========================================
  Files          24       24              
  Lines         613      618       +5     
  Branches        3        1       -2     
==========================================
+ Hits          554      559       +5     
  Misses         59       59              
Impacted Files Coverage Δ
github4s/src/main/scala/github4s/Encoders.scala 96.42% <ø> (-0.13%) ⬇️
...ub4s/src/main/scala/github4s/http/HttpClient.scala 87.50% <100.00%> (+0.54%) ⬆️
.../scala/github4s/interpreters/AuthInterpreter.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b256e...6bdf86e. Read the comment docs.

@juanpedromoreno juanpedromoreno merged commit 5e47006 into master Jun 8, 2020
@juanpedromoreno juanpedromoreno deleted the oauth-bug-fix branch June 8, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants