-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle default_branch
and topics
in Repository
#690
Handle default_branch
and topics
in Repository
#690
Conversation
Looking in https://github.com/github/rest-api-description it is safe to assume that |
Thanks @abestel , would we need to update also the docs? |
Thanks for checking my PR @juanpedromoreno :-) I don't really understand why the Github Worflow failed by the way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pipeline failed for an unrelated issue, no worries about that, I checked your PR and everything looks right.
@@ -30,11 +30,13 @@ final case class RepositoryBase( | |||
updated_at: String, | |||
pushed_at: String, | |||
status: RepoStatus, | |||
default_branch: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Would it make sense to add the new fields at the end? Thinking about an easier way to upgrade for people using the existing model :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to keep the required fields before the fields having a default value (hence the default_branch
here and the topics
all the way down) but I can definitely change it if you think it would be better :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your point makes sense to me too, let's keep it that way 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your time @abestel !
- Decoders was badly formatted after 47degrees#690 - Integration tests were failing, it seems, because of the move from `master` to `main`
No description provided.