Pull request list #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedefernandez
force-pushed
the
ff-issue-69-pull-request-list
branch
from
8c3d5a2 to
e0e2432
Compare
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 79.43% 80.04% +0.61%
==========================================
Files 31 34 +3
Lines 457 471 +14
Branches 2 3 +1
==========================================
+ Hits 363 377 +14
Misses 94 94
Continue to review full report at Codecov.
|
juanpedromoreno
approved these changes
Mar 30, 2017
|
|
||
| class GHPullRequestsSpec extends FlatSpec with Matchers with TestUtils { | ||
|
|
||
| "Repos >> List" should "return a non empty list when valid repo is provided" in { |
There was a problem hiding this comment.
--"Repos >> List" should "return a non empty list when valid repo is provided" in {
++"PullRequests >> List" should "return a non empty list when valid repo is provided" in {??
peterneyens
reviewed
Mar 31, 2017
| @@ -29,5 +29,6 @@ object app { | |||
| type COGH02[A] = Coproduct[GistOp, COGH01, A] | |||
| type COGH03[A] = Coproduct[IssueOp, COGH02, A] | |||
| type COGH04[A] = Coproduct[AuthOp, COGH03, A] | |||
| type GitHub4s[A] = Coproduct[GitDataOp, COGH04, A] | |||
| type COGH05[A] = Coproduct[GitDataOp, COGH04, A] | |||
| type GitHub4s[A] = Coproduct[PullRequestOp, COGH05, A] | |||
There was a problem hiding this comment.
We could look into using the trick they use in quasar to build nested coproducts.
That way we could write :
type Github4s[A] = (
PullRequestOp
:\: GitDataOp
:\: AuthOp
:\: IssueOp
:\: GistOp
:\: RepositoryOp
:/: UserOp
)#M[A]But if we are moving to freestyle once it is released, it is probably not worth it.
There was a problem hiding this comment.
Yeah, probably not worthy at this point but it's good to know it for other cases, thanks for sharing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
Please @juanpedromoreno could you review? Thanks