Update sbt-scalajs, scalajs-compiler, ... to 1.8.0 #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedefernandez
force-pushed
the
update/sbt-scalajs-1.8.0
branch
from
452e93e to
9a1b632
Compare
jisantuc
reviewed
Jan 21, 2022
Comment on lines
+7
to
+24
| object TestContext { | ||
| // Why is this context distinct from the global execution context that Scala provides | ||
| // out of the box? | ||
| // In short, because browsers / JS are _very different_ from the JVM. Copying / pasting | ||
| // from the macrotask executor's explanation of why that library exists in its README: | ||
| // (https://github.com/scala-js/scala-js-macrotask-executor/tree/v1.0.0) | ||
| // | ||
| // "Unless you have some very, very specific and unusual requirements, this is the optimal | ||
| // ExecutionContext implementation for use in any Scala.js project. | ||
| // If you're using ExecutionContext and not using this project, you likely have some serious | ||
| // bugs and/or performance issues waiting to be discovered." | ||
| // | ||
| // This library goes through the trouble of providing this special execution context and | ||
| // reorganizing just to provide that context in tests to make it more obvious for downstream | ||
| // JS consumers what to fix / how to make a pretty menacing warning go away. | ||
|
|
||
| val context: ExecutionContext = Implicits.global | ||
| } |
There was a problem hiding this comment.
This is the meat of the change -- you can see the README for more details. Scala.js 1.8.0 introduced warnings about using Scala's global execution context: https://www.scala-js.org/news/2021/12/10/announcing-scalajs-1.8.0/
This happened only in tests but still required repair. The warning could have been suppressed, but then downstream consumers of the JS lib would have had to figure it out on their own. This seems better, though the cost is pretty high -- CrossProject.Pure was no longer sufficient since we know have platform-specific code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
from 1.7.1 to 1.8.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
Files still referring to the old version number
The following files still refer to the old version number (1.7.1).
You might want to review and update them manually.
Ignore future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains