Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GithubPublicEvent schema #830

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Conversation

javimartinez
Copy link
Contributor

After #817 the tests for the following operations are failing:

  • List public organization events
  • List repository events

That's because the expected schema in the code doesn't match with the JSON returned by the GitHub API. The field repo.full_name doesn't exist; instead, we can get the repo.name field.

For further reference: https://docs.github.com/en/rest/activity/events#list-public-repository-events, https://docs.github.com/en/rest/activity/events#list-public-repository-events

Copy link
Member

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @javimartinez

@javimartinez javimartinez merged commit decd4a3 into main Sep 23, 2022
@javimartinez javimartinez deleted the fix-github-public-event-schema branch September 23, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants