Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ts type cherry-picking #226

Merged
merged 1 commit into from
Jan 11, 2019
Merged

fix ts type cherry-picking #226

merged 1 commit into from
Jan 11, 2019

Conversation

jquense
Copy link
Member

@jquense jquense commented Jan 8, 2019

tested on one of our projects and it seemed to work.

We should probabably migrate the actual types to the files but i didn't want to spend time on it

@taion
Copy link
Contributor

taion commented Jan 8, 2019

i thought you were moving this to 4c/file-butler though? or is this just part of it

@jquense
Copy link
Member Author

jquense commented Jan 8, 2019

we could move the cpy bit to file-butler. i'm not sure if there is more that would be worth moving? We could generate individual files but probably should just write the types in the files vs doing that

@taion
Copy link
Contributor

taion commented Jan 8, 2019

ahh okay. well, this is fine then, but fix CI

@taion taion merged commit abe7dee into master Jan 11, 2019
@taion taion deleted the cherry-pick branch January 11, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants